koila icon indicating copy to clipboard operation
koila copied to clipboard

Incompatible with einops

Open CreamNuts opened this issue 2 years ago • 3 comments

Thanks for your nice project. But it is not compatible with einops. Einops is convenient for pytorch user, and I think many people use it. I hope it works on einops, too. Thank you.

CreamNuts avatar Nov 30 '21 08:11 CreamNuts

Good point. I'll be working on it. Feel free to add more feature requests!

rentruewang avatar Nov 30 '21 10:11 rentruewang

Ok. After quickly skimming over einops's source code, I noticed that they call torch.* functions behind the scenes. That means their functions will directly work with Koila, because Koila uses PyTorch's extension API.

With that being said, not all torch.* functions are implemented yet, and it probably requires some testing. So I'll leave it open for now, and see what I can do when I have some time.

rentruewang avatar Nov 30 '21 15:11 rentruewang

I'm looking forward to implementing it as soon as possible.

CreamNuts avatar Dec 01 '21 04:12 CreamNuts