[Bug] - `files.exclude` is always updated even when renpy.excludeCompiledFilesFromWorkspace is false

[multimokia]

Would it be possible to make it so we can opt out of the automatic generation of files.exclude in local settings?

If I keep "renpy.excludeCompiledFilesFromWorkspace": false, in my main settings.json file, I notice every time I load a project, there's untracked changes to my local settings.json as the extension keeps adding the compiled files to it, even if the patterns are all set to off.

However this behaviour seems redundant as there's no need to add them there. Personally I'd love it if this wouldn't keep being re-added!

[duckdoom4]

I was hoping the lasted merge from @LuqueDaniel fixed this. (See https://github.com/LuqueDaniel/vscode-language-renpy/issues/172) Are you on the new version? (Released just now)

[LuqueDaniel]

The conditional will have to be modified to check the value of renpy.excludeCompiledFilesFromWorkspace.

https://github.com/LuqueDaniel/vscode-language-renpy/blob/7fab9218640384ed8fb473045d67fe8f5dd8aaa0/src/extension.ts#L77-L81

[multimokia]

Can confirm this is still on latest

[LuqueDaniel]

Yes, because what I fixed was the overwriting of other values that may have files.exclude #172 .

I'll change it so that it only writes the values in case the renpy.excludeCompiledFilesFromWorkspace option is enabled.

[multimokia]

Awesome, thank you!

[duckdoom4]

@LuqueDaniel We should compare the values in the config to the new values. Cus we need to make sure that if 'hide' is set to false, it also updates the config values.

As mentioned in #172, I've also done this with the other config here. (But feel free to do it in another way.)