vscode-language-renpy icon indicating copy to clipboard operation
vscode-language-renpy copied to clipboard

Incorrect syntax highlighting on string concatenation with text tags

Open multimokia opened this issue 1 year ago • 3 comments

Extension version

2.1.1

Issue description

image

As shown in the image, the + quip + in both say calls are highlighted as strings despite not being within quotation marks.

Scope inspector screenshots

image image

Code

label test:
    $ quip = "some quiplist choice"
    $ renpy.say(m, "{cps=*3}" + quip + "{/cps}")

    python:
        renpy.say(m, "{cps=*3}" + quip + "{/cps})

    return

multimokia avatar Jul 16 '22 21:07 multimokia

Awesome, thanks for this. That makes the issue a lot more clear. I'm currently unable to check myself. Could you tell me if this also happens outside of python blocks/$ lines

duckdoom4 avatar Jul 16 '22 22:07 duckdoom4

Sure. image

In this case the closing tag not being present is a typo, but we see the behaviour is still present, and will span multiple lines. image

multimokia avatar Jul 17 '22 16:07 multimokia

Thanks for the update. I'll look into it when I find the time :)

duckdoom4 avatar Jul 18 '22 09:07 duckdoom4