vscode-language-renpy icon indicating copy to clipboard operation
vscode-language-renpy copied to clipboard

[Suggestion] Clear existing *rpyc button

Open pjpollina opened this issue 2 years ago • 6 comments

Dunno if it's in the scope of what this plugin is going for but an easy button to clear out old rpyc files since they're hidden by default would be nice. In bash its as simple as running find . -type f -name '*.rpyc' -delete, which on one hand makes it kinda redundant but hey, why not?

pjpollina avatar Jun 14 '22 14:06 pjpollina

Sounds cool. Not sure where you would place such a button though. One thing you can do for sure is add a command for it.

(Let me know if you need some info on how you would implement such a command)

duckdoom4 avatar Jun 14 '22 14:06 duckdoom4

Yes, a command is the best option.

LuqueDaniel avatar Jun 14 '22 22:06 LuqueDaniel

This is strongly not recommended.

The information in rpyc files is needed for upgrades and loading save files built with previous versions of your scripts. Deleting the files will break compatibility with save games and should only be done as a last resort. Force compile in the launcher is the preferred way to fix issues with rpyc files.

https://www.renpy.org/doc/html/build.html#the-old-game-directory https://patreon.renpy.org/rpyc.html

rdurfee avatar Jun 16 '22 03:06 rdurfee

In that case I think it would be best not to include this in the plugin. As to not give the idea to the user this is something that should be done.

duckdoom4 avatar Jun 16 '22 06:06 duckdoom4

I disagree, as long as it's documented with that message in mind there's no reason not to include it for people who face far more issues manually having to clear out old rpyc files than loading old saves. I doubt many people who use the VSCode command palette are types that would do something like that without understanding the implications.

Of course, that's just my opinion, I'll respect whatever Jelle and Luque decide is best for the plugin.

pjpollina avatar Jun 17 '22 14:06 pjpollina

How about a middle ground, a command that detects unlinked .rpyc files (rpyc files that don't have a corresponding rpy file) and automatically creates/moves the old game directory ?

KiloOscarSix avatar Jul 02 '22 16:07 KiloOscarSix

Hello. May I take on adding the command that migrates old .rpyc files to the old game directory?

a2937 avatar May 10 '23 13:05 a2937

@a2937 Sure! There is no one working on this feature. Thank you for contributing!

LuqueDaniel avatar May 10 '23 15:05 LuqueDaniel