renovate icon indicating copy to clipboard operation
renovate copied to clipboard

feat(kustomize): support OCI helm charts

Open chancez opened this issue 6 months ago • 1 comments

Changes

Correctly handle OCI charts with the kustomize manager. This requires setting the datasource to docker and replacing the oci:// scheme with https://. For the implementation, I simply adapted the approach used in the helmv3 manager. I do think there's more to do in terms of support, like digests, and probably auth, but for my use-case, this was sufficient. I tested with, and without auth against a quay.io registry.

Context

Renovate was updated to handle updating helmCharts within a kustomization.yaml in #12628. However, in Kustomize 5.2.0 it got support for inflating helm charts stored in OCI repositories. Currently renovate fails to update these dependencies because it simply treats OCI helm repos the same as regular helm repos, and fails.

There were similar issues with other managers, but nothing for Kustomize that I could find. The related issues for other managers I found are:

  • #11584
  • #18185
  • #19017
  • #19869
  • #22291
  • #24183

Documentation (please check one with an [x])

  • [x] I have updated the documentation, or
  • [ ] No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • [ ] Code inspection only, or
  • [ ] Newly added/modified unit tests, or
  • [ ] No unit tests but ran on a real repository, or
  • [x] Both unit tests + ran on a real repository

chancez avatar Feb 08 '24 19:02 chancez

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 08 '24 19:02 CLAassistant

:tada: This PR is included in version 37.243.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

renovate-release avatar Mar 13 '24 16:03 renovate-release

Awesome thanks everyone!

chancez avatar Mar 13 '24 16:03 chancez

I'm glad to report that I'm seeing this working in a few of my repos now. 🎉

MPV avatar Mar 15 '24 15:03 MPV

I just went back into @thomaschaaf's minimal reproduction repo below and it got me thinking: is this working fully as desired yet?

See:

  • https://github.com/thomaschaaf/renovatebot-helm-oci/issues/2

Here's what Renovate changed in that issue description ~18 hours ago:

Skärmavbild 2024-03-15 kl  16 06 35

MPV avatar Mar 15 '24 15:03 MPV

please open a new discussion

viceice avatar Mar 15 '24 16:03 viceice