renovate icon indicating copy to clipboard operation
renovate copied to clipboard

fix(package-rules): remove edge case if no depName packageRules are defined

Open secustor opened this issue 2 years ago • 1 comments

Changes

Removes an edge case when no packageRules are defined and no depName is supplied.

Current behavior is to skip packageName logic if depName is not defined and there for not apply the if no matchers are defined default to true.

Now the standard logic applies too if no depName is defined.

Context

https://github.com/renovatebot/renovate/pull/16865#issuecomment-1202256161

Documentation (please check one with an [x])

  • [ ] I have updated the documentation, or
  • [x] No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • [ ] Code inspection only, or
  • [x] Newly added/modified unit tests, or
  • [ ] No unit tests but ran on a real repository, or
  • [ ] Both unit tests + ran on a real repository

secustor avatar Aug 03 '22 08:08 secustor

No other test showed this behavior during the implementation of #16865

secustor avatar Aug 03 '22 21:08 secustor

:tada: This PR is included in version 32.154.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

renovate-release avatar Aug 10 '22 15:08 renovate-release