renovate icon indicating copy to clipboard operation
renovate copied to clipboard

feat(autodiscover)!: move autodiscovery filter from string to array

Open secustor opened this issue 2 years ago • 5 comments

Changes

Change type of autodiscoverFilter from string to array.

Context

tracking issue: https://github.com/renovatebot/renovate/issues/8763 Supersedes #13100

This is a breaking change which affects administrators running a self hosted instance which uses CLI or ENV for filter configuration and uses ,. e.g. this forces admins which uses minimatches like this project/{a,b,c,d,*-app} to migrate to regex ( /project/(a|b|c|d|.*-app)/ ) or to use a config file.

Documentation (please check one with an [x])

  • [x] I have updated the documentation, or
  • [ ] No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • [ ] Code inspection only, or
  • [ ] Newly added/modified unit tests, or
  • [ ] No unit tests but ran on a real repository, or
  • [x] Both unit tests + ran on a real repository

secustor avatar Jul 11 '22 14:07 secustor

Does it even make sense to have more than one negation?

rarkins avatar Aug 26 '22 03:08 rarkins

no, but users tend to think they can do it now. so we should document it's not possible.

viceice avatar Aug 26 '22 04:08 viceice

I'm currently trying to use the list and the renovate-config-validator is saying that the array on my json file should be a string.

ERROR: config.json contains errors
       "errors": [
         {
           "topic": "Configuration Error",
           "message": "Configuration option `autodiscoverFilter` should be a string"
         }
       ]

Is this a problem with the validator, my config or just not available yet?

ab-ty avatar Aug 29 '22 09:08 ab-ty

this isn't yet released, so you can't use it.

viceice avatar Aug 29 '22 09:08 viceice

Is this gonna get merged anytime soon? I'm currently trying to set up a pretty big deployment of renovate and would like to use this feature asap

ab-ty avatar Sep 05 '22 08:09 ab-ty