renovate icon indicating copy to clipboard operation
renovate copied to clipboard

Replace `pretty-quick` with `lint-staged`

Open HonkingGoose opened this issue 2 years ago • 5 comments

Describe the proposed change(s).

Replace pretty-quick --staged with okonet/lint-staged. Include Prettier and the different linters in the pre-commit hook.

https://github.com/renovatebot/renovate/blob/8d9e3be6f3b73f856a87eee31d4aff8c196ced23/.husky/pre-commit#L4

https://github.com/renovatebot/renovate/blob/8d9e3be6f3b73f856a87eee31d4aff8c196ced23/package.json#L294

Todo:

  • [ ] Install lint-staged as dev dependency
  • [ ] Check where we run pretty-quick
  • [ ] Replace pretty-quick commands with lint-staged commands
  • [ ] Run ls-lint
  • [ ] Run eslint
  • [ ] Run markdown-lint
  • [ ] Open PR

HonkingGoose avatar Jun 13 '22 09:06 HonkingGoose

  • does this lint-staged replace pretty-quick functionality fully?
  • Are you willing to do this or should we do it ?

PhilipAbed avatar Jun 13 '22 10:06 PhilipAbed

  • does this lint-staged replace pretty-quick functionality fully?

I think that's what @viceice and @astellingwerf want on Slack? I'll let them respond to that part of the question.

  • Are you willing to do this or should we do it ?

I'll let somebody else do it. 😉

HonkingGoose avatar Jun 13 '22 10:06 HonkingGoose

cool, we'll take it then, thanks!

PhilipAbed avatar Jun 13 '22 10:06 PhilipAbed

  • does this lint-staged replace pretty-quick functionality fully?

yes

  • Are you willing to do this or should we do it ?

maybe 🙃

viceice avatar Jun 13 '22 10:06 viceice

Hi, I am new to this project and interested in picking this up.

prophet1906 avatar Sep 13 '22 11:09 prophet1906