Saketh Kalaga

Results 117 comments of Saketh Kalaga

@akaokunc sorry this hasn't moved for a couple weeks. I will spend some time this week to go through the PR. I'm also considering unifying the way credentials are passed...

`go.mod` at `github.com/prometheus/client_golang v1.20.4`

Thanks @amold1 for addressing my review. I just have a few more nit comments that I will post soon - it will not be any work to address them. Also,...

Hi @amold1, sorry for the late reply. Will get back to you soon. Will take a look at the tests that are currently present for options like this, and will...

# Testing locally The following only covers the case with one `etcdbrctl` process with one `etcd` process. * One would need at least three terminal sessions to test `etcdbrctl` as...

@amold1 For the logs seen in https://github.com/gardener/etcd-backup-restore/pull/719#pullrequestreview-1971891869, the command that I ran was: ``` ./bin/etcdbrctl server --storage-provider=S3 --store-container=$YOUR_STORAGE_CONTAINER_NAME --store-prefix=etcd-test ``` A more comprehensive description of the setup excluding the command...

@amold1 I'd rather not run a container which I've not built myself. I've taken a look at your etcd-backup-statefulset.yaml, and I see that you're running etcd-backup-restore with the `snapshot` command....

Alright. I'll see if I'm missing something.

@amold1 I've taken the liberty to make a few changes and pushed them to the PR. Take a look and let me know if you have any questions/comments/inputs. Primarily, the...

@amold1 Please add relevant documentation for this PR here: https://github.com/gardener/etcd-backup-restore/blob/17e447b2fd4cb1291e415130f70fa4017f4cc7b7/docs/deployment/getting_started.md?plain=1#L14-L18. I'll let you know more about tests.