php-k8s icon indicating copy to clipboard operation
php-k8s copied to clipboard

Multiple bumps & fixes to CI versions (Kubernetes, GH Actions, PHP)

Open cuppett opened this issue 1 year ago • 5 comments

Multiple versions being tested now out of support as well as a few fixes:

  1. Caching of composer dependencies wasn't working, fixed
  2. Bumped minikube to the current latest
  3. Updated to the most recent 3 kubernetes versions
  4. Fixed an issue observed once where minikube picked the podman engine (and it didn't work for CNI). Explicitly setting docker to avoid that flake in the future.
  5. Added PHP 8.3

Note: 1.25 & 1.26 also works and passes tests, but it would add more versions and there's a couple spots in the project and docs that say "latest 3", so I left that off the back.

cuppett avatar Aug 31 '23 10:08 cuppett

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.68%. Comparing base (5d9d356) to head (a7980e3).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #380      +/-   ##
============================================
+ Coverage     94.17%   94.68%   +0.51%     
  Complexity      700      700              
============================================
  Files            70       70              
  Lines          1837     1788      -49     
============================================
- Hits           1730     1693      -37     
+ Misses          107       95      -12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 31 '23 11:08 codecov[bot]

Added a few more commits to fix minor issues, bring in some of the dependabot changes and add PHP 8.3.

Summary:

  • Removes deprecated vierbergenlars/php-semver in favor of composer/semver (adds testcase)
  • Adds PHP 8.3
  • Updates Kubernetes versions from 1.24, 1.25, 1.26 to 1.26, 1.27, 1.28
  • CI version updates to actions/checkout, actions/cache, minikube
  • Some minor style corrections to try and help those bots a bit

cuppett avatar Dec 02 '23 12:12 cuppett

@rennokki These tests are coming back clean. Revisiting this, I bumped a few other versions and dependencies. Added PHP 8.3, you may want to drop 8.1 since we had 8.0 dropped during this phase of the lifecycle.

cuppett avatar Dec 02 '23 13:12 cuppett

@rennokki Anything else needed to merge this one? I'm happy to make any other adjustments to get this one in.

cuppett avatar Feb 28 '24 14:02 cuppett

@rennokki I cleaned this up for easier review squashing like for like PRs that stretched over time. Also, removed the overlap with the deprecated package PR. This has just version bumps in the ci.yml file to current versions of kubernetes, laravel, PHP and GH actions. All checks clean.

cuppett avatar Apr 11 '24 00:04 cuppett