atom-import-sort icon indicating copy to clipboard operation
atom-import-sort copied to clipboard

Sorting seems to not follow the GIF demo

Open zedtux opened this issue 6 years ago • 0 comments

The GIF demo is showing exactly what I'd like to have, but when I'm running the package using CTRL + ALT + o, I don't have the excepted result.

Here is an example file before sorting :

import 'core-js'

import { AppRegistry } from 'react-native'
import App from './src/App'
import { name as appName } from './app.json'

AppRegistry.registerComponent(appName, () => App);

And then after sorting :

import 'core-js'

import App from './src/App'
import { AppRegistry } from 'react-native'
import { name as appName } from './app.json'

AppRegistry.registerComponent(appName, () => App);

The local project import statement import App from './src/App' is coming before the external library import import { AppRegistry } from 'react-native' which is wrong as stated by eslint.

CTRL + ALT + o shouldn't have change the order of imports, it could have added an empty line between the external and local libraries imports.

zedtux avatar Oct 10 '18 04:10 zedtux