react-native-tensorflow icon indicating copy to clipboard operation
react-native-tensorflow copied to clipboard

updating to latest tensorflow and required android sdk versions

Open shokimble opened this issue 7 years ago • 7 comments

Made changes to support tensorflow 1.8.0 and to support play store/react native requirement of all new apps requiring SDK level 26 or above

shokimble avatar Jul 06 '18 22:07 shokimble

Sorry this is only for Android. I'll look at adding IOS tomorrow. Might be best to hold off any merge until then.

shokimble avatar Jul 06 '18 22:07 shokimble

can anyone merge this?

socksrust avatar Aug 27 '18 07:08 socksrust

cc @shokimble

socksrust avatar Aug 27 '18 07:08 socksrust

i already tested for android and works

socksrust avatar Aug 27 '18 07:08 socksrust

@shokimble can you fix the travis build?

I believe you just need to update android-23 to android-26 under

 android:
   components:
     // here ...

gianpaj avatar Sep 15 '18 13:09 gianpaj

I tried it in android and it works. However im getting a different result in android. Have you all encountered this? I converted my keras model to pb.

jazzystring1 avatar Sep 19 '18 11:09 jazzystring1

Sorry for late reply one this. The main reason I was holding off on doing this change was that the Android version would diverge from the iOS one. It though looks like that Google will not update the iOS version anymore as the way forward is using Tensorflow Lite. For the time being we might just update the Android version on it's own and update the Readme that there the Android Tensorflow version is different than the iOS one until we upgrade to Tensorflow Lite?

reneweb avatar Oct 28 '18 17:10 reneweb