René Meusel

Results 339 comments of René Meusel

Here's another iteration ([godbolt](https://godbolt.org/z/ovKq91Y8Y)) that splits "building" and "consuming" into two classes. We hope that this results in a clearer interface that's harder to misuse: i.e. users cannot reach into...

To my mind, this API is converging nicely (even though CI is probably not yet happy). As [suggested a few weeks ago](https://github.com/randombit/botan/pull/4318#issuecomment-2297990007), the options builder now incorporates _all degrees of...

Rebased to the 3.6.0 tag. Several conflicts in ML-DSA and SLH-DSA code paths, as was expectable.

Rebased once more. The fix for SLH-DSA in 3.6.1 created a conflict again.

> Figure out a story for FFI. Some initial idea (also regarding #4411). Inspired by: https://stackoverflow.com/questions/17604811/builder-pattern-in-c ```C botan_pk_sign_options_t options; botan_pk_sign_config_create(&options, rsa_private_key); botan_pk_sign_config_set_ptr(options, BOTAN_PK_SIGN_RNG, rng); botan_pk_sign_config_set_str(options, BOTAN_PK_SIGN_PADDING, "PSS"); botan_pk_sign_config_set_str(options, BOTAN_PK_SIGN_HASH, "SHA-256");...

@randombit I'd love to restart the discussion on this and hopefully converge on a design for the builder. We'd like to develop the pre-hash feature for SLH-DSA and ML-DSA based...

Rebased, resolved conflicts and adapted to the latest changes on master. Most notably: the TPM2 wrapper needed some significant love to be able to handle `PK_Signature_Options&`. Other conflicts were introduced...

Rebased once more to solve conflicts mostly with #4600 and compilation issues introduced in #4642.

> OK I think we just need to adjust the logic in Policy::choose_key_exchange_group. ... I was about to say that. Currently, the code there optimizes for round-trips and avoids sending...

> I expect it looks something like a 2-tier selection Sounds reasonable to me as a default policy. I was thinking to propose an additional policy setting like `prefer_pqc_groups_when_possible()`. But...