René Meusel

Results 316 comments of René Meusel

Rebased after the underlying #3869 needed to get conflicts resolved after #3908 was merged. Also, the code here needed minor conflict resolving due to #3908.

> I'll review LMS after this is rebased post merge Done. I merged #3869 and rebased. No history rewrite was done.

Rebased to fix conflicts on master (likely introduced by merging #3933).

I noticed that you're using a sort-of strong type to write the output value to. The type is defined as: ```C++ struct Hash256 { unsigned char bytes[32]; }; ``` ......

I [successfully reproduced the crash in my fork](https://github.com/reneme/trantor/pull/1), and after fixing the UB I pointed out, the crash seems to go away. Even running the unit tests many times in...

@marty1885 Any news here? Otherwise, I'd like to close the issue

For the record, here's an example of the hoops one needs to jump through to load a private key that is not wrapped in PKCS#8: https://github.com/randombit/botan/discussions/3902#discussioncomment-8476815.

Force-pushed after #3888, to fix CI.

Rebased and resolved conflicts after #3874 got merged.

Thanks for the review! We have a further iteration for this in the pipeline, though. It'll be a few weeks before we're done with it, unfortunately. Currently busy preparing the...