Rene Leonhardt
Rene Leonhardt
Great contribution, I hope it gets reviewed ❤️ Would a small unit test be possible?
Did you try the workflow commands? https://github.com/asg017/sqlite-vec/blob/main/.github/workflows/release.yaml#L28 There is no `Makefile.orig` here. ```shell $ ./scripts/vendor.sh ... $ make clean loadable static cc -fPIC -shared -Wall -Wextra -Ivendor/ -O3 -mcpu=apple-m1 -DSQLITE_VEC_ENABLE_NEON...
It seems like a problem with Deno, I tried 2.5.1. npm and bun work. Could you open an issue there?
It seems to happen inside `NpmResolutionSnapshot::add_pkg_reqs()`, I guess not all expected errors (like an empty map or a map which is null) from the registry result are being handled. https://github.com/denoland/deno_npm/blob/main/src/resolution/snapshot.rs#L300
@hongjiaherng FYI my PR last year provided that exact functionality (show the next number for specific type): https://github.com/callowayproject/bump-my-version/pull/88
> There are a lot of unrelated changes (code style, `[list.size()]` instead of `[0]`) - could you please revert them and focus this PR on one change? Just to be...
Ok, I'll try to disect everything.
Do you know why `Execution failed for task ':testcontainers:japicmp'`? The logs download didn't contain the mentioned `build/reports/japi.html`.
> @reneleonhardt it looks like you introduced a binary incompatible change. You can run the same task locally and check the report - it will tell you where. Strange tool,...
Is something missing or can this be merged?