Renaud Chaput

Results 390 comments of Renaud Chaput

Seems good. Maybe use a more expressive default name, like `app/javascripts/components/serverRendering.js`? Also this should be a configuration option, and allow an array of files to be loaded.

I have not got time to really work on server-rendering. If you would like to have a stab at it, feel free! I outlined my ideas in this issue and...

Nice! This seems like a good start. There is a related issue in the Webpacker repo: https://github.com/rails/webpacker/issues/842 What is the issue with `style-loader` and server-rendering?

Well, server rendering should not worry about styles at all and not output anything related (except for css modules). Hydrating a server-rendered component is a mandatory feature, I dont see...

Ok I see how it works. Let me correct what I said by "server-rendering should ignore `style-loader` and other CSS-related webpack loaders :) For production your stylesheets will be compiled...

@tomasc I havent got time to work on this yet. Feel free to tackle it if you want! The preferred way is to open a PR as soon as you...

Can you please show the whole `application.js` file (or at least the `WebpackerReact.setup` call and any Webpacker -related lines)? Also, what is displayed in your console when you load the...

This is a very valid use-case for non-SPA applications. Feel free to submit a PR to implement this. One point to be careful about is how it interacts with hot-reloading.

Yes, you can find more context here: https://github.com/renchap/webpacker-react-example/pull/2#issuecomment-278063213 We havent been able to find documentation on the internals for HMR in Webpack 2. I would have preferred a 100% JS...

@sevos do you think we can have a simpler pure-JS solution? I tried again to look at how to make this work with Webpack & hot-reloading, without any results. I...