Jean-Baptiste RENAULT

Results 27 comments of Jean-Baptiste RENAULT

Yes, you can. The generation of the python code to generate numpy style comments is still pretty experimental. The branch is named **sphinx_documentation**. I should add a *readme.md* in the...

Looks good, but I might have done the check at the beginning for clarity: ```Matlab %-------------------------------------------------------------------------% function [ TRout ] = TriFillPlanarHoles( TRin) FB = TRin.freeBoundary; if isempty(FB) % warning...

I think it's the way to go. An other possibility is to select all vertices on the navicular bone that lie within x mm of the talus articular surface, but...

Yes, I also think it will be the easiest way, but I have not the geometry of the navicular in mind.

I've read the documentation of *m2html*. Correct me if I'm wrong, but there is no fix standard to which the in-script documentation must conform. So, @modenaxe, when adding/updating the function...

Indeed, TriDistanceMesh.m is not used anywhere. The code doesn't make much sense I think it was not terminated. The original goal was to find the signed distances between points from...

About the comment format, that works for me I will create a branch from master and do the the comments on GIBOC-Core there

I've started to comment triangulation functions [see this commit](https://github.com/modenaxe/msk-STAPLE/commit/5923fc5f0ebe533c006f17c743fd6b81ff4a0261). Do not hesitate to tell me if the comments are unclear.

@modenaxe There is still a lot I have to do in terms of commenting, but before continuing I wanted to let you know that I found a contribution to [sphinx](https://www.sphinx-doc.org/en/master/index.html)...

Ok, with sphynx we a have a choice between two main types of Docstrings format ; [Google Style vs. Numpy Style](https://www.sphinx-doc.org/en/master/usage/extensions/napoleon.html). I've just tested them, and they both works with...