appengine-maven-repository icon indicating copy to clipboard operation
appengine-maven-repository copied to clipboard

Published 20 hours ago • verified publisher icon renaudcerrato

content type not returned properly for xml files

Open jefimm opened this issue 4 years ago • 3 comments

The https://github.com/renaudcerrato/appengine-maven-repository/blob/master/src/main/java/repo/resource/RepositoryResource.java#L104 does not work properly for the *.xml files as the GCP does not set the content type for the XML and the *.xml files are returned as 'application/octet-stream' This causes issue with some tools that rely on the content type

jefimm avatar Sep 17 '20 16:09 jefimm

Mmmm... It sounds like your application is not setting the Content-Type header : the mime is taken from it. Can you check ?

https://github.com/renaudcerrato/appengine-maven-repository/blob/master/src/main/java/repo/resource/RepositoryResource.java#L135

renaudcerrato avatar Sep 23 '20 08:09 renaudcerrato

might be, we are using https://leiningen.org

jefimm avatar Sep 23 '20 08:09 jefimm

I'd suggest to report a bug to that tool, but we may also add some basic mime-type detection based on file extension. PR are still welcome ;)

renaudcerrato avatar Sep 23 '20 10:09 renaudcerrato