FloatingSearchView icon indicating copy to clipboard operation
FloatingSearchView copied to clipboard

Fade in crash

Open tuanna-hsp opened this issue 8 years ago • 10 comments

capture capture2

tuanna-hsp avatar Mar 11 '16 13:03 tuanna-hsp

Are you using Proguard?

renaudcerrato avatar Mar 11 '16 13:03 renaudcerrato

Yes, but no rules specified for your library.

tuanna-hsp avatar Mar 11 '16 13:03 tuanna-hsp

Before going further, try to disable Proguard, and test again.

renaudcerrato avatar Mar 11 '16 13:03 renaudcerrato

These are crashes by our user, i couldn't recreate it.

tuanna-hsp avatar Mar 11 '16 14:03 tuanna-hsp

As you can see here, there's no NPE possible since icon != null for sure - I suspect the object animator to fails because it can't find the getProgress()/setProgress() methods (probably removed by proguard?)

renaudcerrato avatar Mar 11 '16 14:03 renaudcerrato

Agree that those method maybe removed, but why crash only happenned on some user devices only? (All 4.x) On Mar 11, 2016 21:31, "Cerrato Renaud" [email protected] wrote:

As you can see here https://github.com/renaudcerrato/FloatingSearchView/blob/master/library/src/main/java/com/mypopsy/widget/FloatingSearchView.java#L458, there's no NPE possible since icon != null - I suspec the object animator to fails because it can't find the getProgress()/setProgress() methods (probably removed by proguard?)

— Reply to this email directly or view it on GitHub https://github.com/renaudcerrato/FloatingSearchView/issues/10#issuecomment-195389439 .

tuanna-hsp avatar Mar 14 '16 00:03 tuanna-hsp

We are also experiencing this crash. It is reproducible every time on a Galaxy S3 running 4.0.4. The last answer here seems like it may be related http://stackoverflow.com/questions/24105843/choreographer-nullpointerexception

smithaaron avatar Mar 25 '16 17:03 smithaaron

Are you using Proguard too? That code is in production for one my application already, and didn't experienced such crashes (no proguard).

renaudcerrato avatar Mar 25 '16 17:03 renaudcerrato

No, don't think so. Have: minifyEnabled false in my gradle build file.

smithaaron avatar Mar 25 '16 17:03 smithaaron

I'm unable to reproduce it... Can someone provide a test project? Pull Requests are welcome BTW.

renaudcerrato avatar Apr 12 '16 14:04 renaudcerrato