react-sizes icon indicating copy to clipboard operation
react-sizes copied to clipboard

Static properties should be copied over

Open such opened this issue 6 years ago • 0 comments

Hey,

Thanks a lot for this library! It appears that you do not copy static methods as described here: https://reactjs.org/docs/higher-order-components.html#static-methods-must-be-copied-over It seems the convention is that all HOC should do that. The behaviour is somewhat unexpected otherwise. Are you planning on adding it to the library?

In the meantime, I'm using this workaround:

const WithHoc = compose(
  withRouter,
  withSizes(mapSizesToProps),
  withStyles(styles)
)(WrappedComponent);

hoistNonReactStatic(WithHoc, WrappedComponent);

export default WithHoc;

Thanks!

such avatar Jul 17 '18 15:07 such