liac-arff icon indicating copy to clipboard operation
liac-arff copied to clipboard

Possible bug in test_loads.py

Open mfeurer opened this issue 9 years ago • 7 comments

Hi, I think I stumbled upon a bug in test_loads.py in the method test_format_correct. This test should not pass in my opinion because the only line of data is the same line which contains @data.

This also raises the question if a line which denotes @data should be checked with a u_row.startswith(). I propose to use a u_row.startswith() followed by a check if there is something else in the same line.

mfeurer avatar Aug 11 '15 09:08 mfeurer

@renatopp can you please have a look at this?

mfeurer avatar Sep 11 '15 11:09 mfeurer

Hey, @mfeurer, despite the ARFF documentation, I always test all our ARFF examples within Weka. Thus, if Weka opens a given file, I think we should open too.

For instance, this example ARFF can be opened with Weka (3.7+) so I guess there is no problem with this format.

For reference, the example we are discussing here is:

@relation "software metric"
@attribute number_of_files numeric
@attribute "lines of code" numeric
@attribute 'defect density' numeric
@data 10,10,10

renatopp avatar Sep 11 '15 15:09 renatopp

I posted an issue over at the wekalist. Let's see what happens.

mfeurer avatar Sep 28 '15 08:09 mfeurer

Hey @mfeurer, any news on this issue?

renatopp avatar Oct 09 '15 13:10 renatopp

They confirmed it's a bug. I wrote again (2 hours ago) to ask whether they are going to change the behaviour. Let's see what happens.

mfeurer avatar Oct 09 '15 13:10 mfeurer

It'll be fixed in the next release.

mfeurer avatar Oct 12 '15 08:10 mfeurer

I just check this with the latest release and WEKA still parses this one :(

mfeurer avatar Mar 14 '18 08:03 mfeurer