Renan Castro

Results 23 comments of Renan Castro

@justinweinberg You should make a PR. Your solution looks good and the same error is happening time to time here.

I think the first required step for having an actual fix for this issue would be a reproduction or a detailed crash log. Without it, unfortunately, it's hard to say...

> @renanccastro, there are detailed logs in my initial post above (they're in collapsed sections which you can expand). I do have Sentry but there are no JS errors so...

> Won't all packages need to keep the side effects for backwards compatibility? Yes, that's the idea @sebakerckhof. We will keep packages as sideEffects: true, unless specified with api.setSideEffects(false) inside...

> @renanccastro But is there a difference between api.sideEffects(false) and not having any api.export() 's ? And if not, does it make sense to introduce the additional call ? Since...

I've left it on dev mode for checking which imports/modules are actually removed. We can replace it with an empty statement, but leaving it like this makes it easier to...

> How is this going? It's now painful working with material-ui icons and react-bootstrap, react-bootstrap-icons. Hi @minhna. It's currently on 2.0.beta-4, and you can already try it out. We are...

Hi @appigram, can you open a separate issue for this? It will be easier to track and also please consider attaching a repro project.

> Hello, I was wondering if **treeshaking** would help to **skip** optional dependencies in **package.json**? > > I ask it because it could solve this [issue](https://github.com/disney/meteor-base/issues/55#issuecomment-880132379). No, that won't solve...

@make-github-pseudonymous-again Good news is that this use-case is also covered by this PR: ![image](https://user-images.githubusercontent.com/3637255/130515911-5b7107d6-fd42-4be8-b136-aec363cdd635.png) ```js import {enUS, nlBE, fr} from 'date-fns/locale' console.log(enUS); ``` It is only including enUS nlBE and...