nodemon icon indicating copy to clipboard operation
nodemon copied to clipboard

Update types and jsdocs

Open zAlweNy26 opened this issue 1 year ago • 1 comments

Fix #2231

I hope I haven't missed (or messed up) anything :)

I didn't understand why there are execOptions both at first level of the settings object and also nested inside execOptions, or did I understand wrong?

zAlweNy26 avatar Oct 13 '24 14:10 zAlweNy26

Deploy Preview for nodemon ready!

Name Link
Latest commit e205557ed77c20a77f2fc629ddda05e050186b0c
Latest deploy log https://app.netlify.com/sites/nodemon/deploys/678cf4caf9e6a00008f93a30
Deploy Preview https://deploy-preview-2232--nodemon.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 13 '24 14:10 netlify[bot]

Following this change, delay option has disappeared and watch and ignore options are duplicated :/

jlowcs avatar Jan 14 '25 14:01 jlowcs

Following this change, delay option has disappeared and watch and ignore options are duplicated :/

By this change are you referring to this: https://github.com/remy/nodemon/pull/2232/files ?

Or have you pulled down this PR directly and are testing it?

remy avatar Jan 14 '25 18:01 remy

Following this change, delay option has disappeared and watch and ignore options are duplicated :/

By this change are you referring to this: https://github.com/remy/nodemon/pull/2232/files ?

Or have you pulled down this PR directly and are testing it?

I'm using the latest version of nodemon and am encountering the type checking issues mentioned above.

jlowcs avatar Jan 14 '25 19:01 jlowcs

@remy I fixed the errors @jlowcs is talking about. Also now the export is correct.

zAlweNy26 avatar Jan 19 '25 12:01 zAlweNy26

Is there any progress on this matter? If any code is used like this after update to version 3.1.8

import nodemon from 'nodemon'

nodemon({
  script: ''
})

then you will get a typescript error "Type 'Nodemon' has no call signatures."

It works perfectly fine in version 3.1.7.

lcxmaple avatar Feb 17 '25 06:02 lcxmaple

Jeez, sorry this took me so long to merge.

remy avatar Apr 23 '25 09:04 remy

:tada: This PR is included in version 3.1.10 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Apr 23 '25 09:04 github-actions[bot]

Was the watch option removed by mistake?

jlowcs avatar May 12 '25 10:05 jlowcs

Was the watch option removed by mistake?

I suspect that's the case, it's certainly still there in JS-land.

remy avatar May 12 '25 15:05 remy