Remington Mallett
Remington Mallett
@raphaelvallat I don't want to throw any wrenches in at this point, but I just considered this. Maybe you can tell me why it's a bad idea? If users aren't...
I'm moving to this after #130 is finalized. Then we can swap reviews π
Looks great to me! If I think of anything else this is a good place to note it π
> I actually might vote for including the new plotting functions in the `evaluation.py` file. Agreed π > I think `test` and `reference` is a good choice. Menghini et al...
@raphaelvallat I'm still in draft mode! I've been making major changes the last few days. Please wait until I leave draft mode before a review, otherwise I'm afraid this will...
No worries! It would just suck if you put in lots of effort on old code. No time wasted so far though, your current comments are still useful and relevant...
Still working out final kinks, but now I think this PR is taking it's final form π A lot of the methods/attributes setup has changed, now with most of the...
Still planning to clean it up more @raphaelvallat I see you're adding comments, feel free but note that the PR is not finalized. Not all code is finished up, especially...
No problem! Actually your early comments are still really helpful, I should just make sure to keep the remote branch up to date (I sometimes have days worth of commits...
Yup @raphaelvallat thanks I needed this bump. Now's a good time for me to prioritize this, so I'll revisit and provide an update this week π