remotion icon indicating copy to clipboard operation
remotion copied to clipboard

Upgrade templates to ESLint 9

Open JonnyBurger opened this issue 1 year ago • 20 comments

We get bunch of deprecation notices now with ESLint 8. VS Code extensions seems to support it now as well..

JonnyBurger avatar Jun 19 '24 12:06 JonnyBurger

$200 if someone is able to upgrade the Hello World template to use ESLint 9 (ideally with Flat Config, but if there is a different way, then it's also okay): https://github.com/remotion-dev/template-helloworld

Criteria: The lint command as well as the VS Code error reporting with the ESLint extension should also keep working.

Maybe an update to @remotion/eslint-plugin and @remotion/eslint-config is necessary, but it should be backwards compatible hopefully. In that case, just comment what changes need to be made.

💎 This issue has a bounty on it!

Read our contributing guidelines:

  • How to contribute: https://www.remotion.dev/docs/contributing/
  • Implementing a new feature: https://www.remotion.dev/docs/contributing/feature
  • Implementing a new option: https://www.remotion.dev/docs/contributing/option
  • Write documentation: https://www.remotion.dev/docs/contributing/docs
  • Bounty information: https://www.remotion.dev/docs/contributing/bounty

/bounty 50

JonnyBurger avatar Jun 19 '24 12:06 JonnyBurger

~~## 💎 $200 bounty • Remotion~~

~~### Steps to solve:~~ ~~1. Get assigned: If you'd like to work on this issue, comment /attempt #4016 below to get assigned~~ ~~2. Submit work: Create a pull request including /claim #4016 in the PR body to claim the bounty~~ ~~3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts~~

~~Thank you for contributing to remotion-dev/remotion!~~

~~Add a bounty • Share on socials~~

algora-pbc[bot] avatar Jun 19 '24 12:06 algora-pbc[bot]

@JonnyBurger can I get this assigned??

abhishek818 avatar Jun 19 '24 16:06 abhishek818

Yes!

JonnyBurger avatar Jun 19 '24 16:06 JonnyBurger

/attempt

volkan0x avatar Jun 21 '24 19:06 volkan0x

Hey @volfcan, you can take up other bounty issues, this one is assigned to me. There are two type of repos, one where everybody takes a attempt at solution and other where a person is assigned first. This repo is the other type.

abhishek818 avatar Jun 22 '24 03:06 abhishek818

@abhishek818 is right!

JonnyBurger avatar Jun 22 '24 06:06 JonnyBurger

current status: close to solution, will push a PR soon.

abhishek818 avatar Jun 24 '24 16:06 abhishek818

Thanks for the update!

JonnyBurger avatar Jun 25 '24 09:06 JonnyBurger

algora tv is down as of now, can i push a PR until then? I will livestream after algora is back, is it then eligible for livestream bounty? @zcesur

abhishek818 avatar Jun 25 '24 12:06 abhishek818

@abhishek818 algora tv is back up! regarding the livestream bounty (which is something very new), let's hear from @JonnyBurger on whether he wants these rewards (if not we'll remove it from the bounty comments in this repo)

zcesur avatar Jun 25 '24 16:06 zcesur

/attempt

ysrael12 avatar Jun 25 '24 18:06 ysrael12

/livestream

Watch abhishek818 on Algora TV Click here to watch abhishek818

abhishek818 avatar Jun 26 '24 04:06 abhishek818

💡 @abhishek818 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

algora-pbc[bot] avatar Jun 26 '24 10:06 algora-pbc[bot]

🎉🎈 @abhishek818 has been awarded $200! 🎈🎊

algora-pbc[bot] avatar Jun 26 '24 12:06 algora-pbc[bot]

@zcesur is it eligible for livestream bounty? PR is merged.

abhishek818 avatar Jun 27 '24 04:06 abhishek818

@JonnyBurger tagging you.. just not sure whom to tag for above.

abhishek818 avatar Jun 27 '24 04:06 abhishek818

hey @abhishek818 Jonny didn't confirm the livestream bounty, also your livestream is unfortunately not eligible since you didn't include camera+mic per the requirements (see bot comment), nonetheless thank you for trying it out!

zcesur avatar Jun 27 '24 10:06 zcesur

Why this issue is still open?

apperside avatar Jul 23 '24 06:07 apperside

Not all of our templates are updated yet, also the one we did not logged some peer dependency issues, so we downgraded for now, waiting for our dependencies to stabilize

JonnyBurger avatar Jul 24 '24 16:07 JonnyBurger

👋 How is the ESLint integration going? What can I do to help move it forward?

Et3rnel avatar Dec 17 '24 21:12 Et3rnel

Is it an open issue? @JonnyBurger

mehul-makvana avatar Jan 25 '25 07:01 mehul-makvana