remotion icon indicating copy to clipboard operation
remotion copied to clipboard

`@remotion/cli`: Allow saving the input props using Cmd+S indicate unsaved changes

Open patsalv opened this issue 1 year ago • 2 comments

Fix #2496 Fix #2067

patsalv avatar Jul 12 '23 09:07 patsalv

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 0:45am

vercel[bot] avatar Jul 12 '23 09:07 vercel[bot]

Some things I noticed:

  • [x] it should not display a click cursor, because there is no action there
  • [x] There is no graying out while the props are saving, like with the other icons
  • [x] We should put a tooltip about how to save
  • [x] If !process.env.KEYBOARD_SHORTCUTS_ENABLED, let's not show the tooltip
  • [x] Let's add a notification "Default props saved" (notificationCenter.current.addNotification - can add a boolean flag to the onSave function)

JonnyBurger avatar Jul 12 '23 13:07 JonnyBurger

Should be ready to merge now 👍

patsalv avatar Jul 17 '23 08:07 patsalv