armadietto icon indicating copy to clipboard operation
armadietto copied to clipboard

Published 20 hours ago • verified publisher icon remotestorage

Displays indeterminate progress indicator on form submission

Open DougReeder opened this issue 2 years ago • 1 comments

When testing locally, to actually see the progress indicator, you may need to use the browser debugging tools to slow the effective network speed.

DougReeder avatar Jul 11 '22 18:07 DougReeder

As this shouldn't cause any one any problems, if no one objects, I'll merge this in a week.

DougReeder avatar Sep 03 '22 22:09 DougReeder

This change seems to break signup for me. When trying to submit the form, the progress indicator shows up, but the POST request is not sent. Commenting out the click handler fixes the problem: https://github.com/remotestorage/armadietto/blob/ae4f16c861196d84afa1f9051cd4e48c58a9cb9c/lib/assets/armadietto-utilities.js#L36-L46

Anybody else seeing this? I'm a bit puzzled as to why it's not working. I don't see a preventDefault() call that would stop the actual submit event.

galfert avatar Nov 28 '22 15:11 galfert

I can reproduce that. Looks like the form submission is broken. Possibly something broke when rebasing. :-(

DougReeder avatar Nov 29 '22 20:11 DougReeder