mob icon indicating copy to clipboard operation
mob copied to clipboard

Mob start timer starts timer with zero minutes if you add a parameter which is not a number

Open hollesse opened this issue 2 years ago • 2 comments

When I do mob timer notanumber this will start a timer with 0 Minutes and directly say mob next. This behavior also applies to mob start notanumber.

In my opinion it should work like this:

mob timer notanumber

  • should fail with an error message

`mob start notanumber``

  • If the configuration MOB_TIMER is set, this value should be used instead and a warning should be printed
  • if configuration MOB_TIMER is not set, a warning should be printed

mob start and MOB_TIMER="notanumber"

  • a warning should be printed

@simonharrer please add your feedback!

hollesse avatar Nov 18 '22 15:11 hollesse

No strong opinion here. It’s okay I guess.

simonharrer avatar Nov 18 '22 16:11 simonharrer

I agree with everything but using an existing MOB_TIMER setting on mob start notanumber. When somebody write notanumber as a command I assume they tried to use this number, but made a mistake typing it. In that case, using MOB_TIMER would not be what they intended to do.

gregorriegler avatar Nov 27 '22 20:11 gregorriegler

fixed with #416

hollesse avatar Apr 17 '24 08:04 hollesse