mob icon indicating copy to clipboard operation
mob copied to clipboard

Use mp3/ogg files instead of voice command

Open jochenchrist opened this issue 4 years ago • 6 comments

Voice engines are a hassle, esp under Windows and Linux. Just use mp3 or OGG files.

https://github.com/faiface/beep looks promising for this.

jochenchrist avatar Nov 04 '21 14:11 jochenchrist

Beep is based on https://github.com/hajimehoshi/oto which requires some other software that may need to be installed by the user manually.

simonharrer avatar Nov 05 '21 16:11 simonharrer

I implemented this for Macs at https://github.com/lizell/mob

Just go

mob install-custom-next file.ogg

or

mob install-custom-next install-custom-next https://file-examples-com.github.io/uploads/2017/11/file_example_MP3_700KB.mp3

and it will be used instead of the voice engine

If you think it is a good idea I could try to add support for Windows and Linux and turn it into a PR?

lizell avatar Dec 03 '21 13:12 lizell

Have a look at https://github.com/remotemobprogramming/mob/pull/235 for my try at it

simonharrer avatar Feb 13 '22 21:02 simonharrer

Why do you remove the configuration of the voice command? Don’t you think it makes sense to give the users the freedom to replace this command?

hollesse avatar Feb 14 '22 06:02 hollesse

Behavior is not fully downwards compatible (see the replacing of %s with the voice message), it will break either way except when introducing yet another configuration option. So instead of adding another configuration option, I eliminated two already existing ones.

simonharrer avatar Feb 14 '22 07:02 simonharrer

I just brought my fork up to date with the latest release. .mob as a user configuration file was added brekaing my original implementation. I added .mob as a dir where one could put configuration. I have changed that now. Here is an alternate PR #236 to #235.

lizell avatar Feb 18 '22 10:02 lizell