remote-jobs icon indicating copy to clipboard operation
remote-jobs copied to clipboard

edit 38 listed companies'

Open Hopelezz opened this issue 2 years ago • 6 comments

📝Title your pull request descriptively. [edit X company] or [add new company - COMPANY]

ℹ️Please read and check the boxes in the list below that apply!

  • [x] This PR contains housekeeping only (URL edits, copy changes etc) - if check, delete other lines that don't apply.

If updating or adding a company, please include details here:

Updates include :

  • MD001/heading-increment/header-increment: Heading levels should only increment by one level at a time [Expected: h3; Actual: h4]
  • MD009/no-trailing-spaces: Trailing spaces [Expected: 0 or 2; Actual: 1]
  • MD012/no-multiple-blanks: Multiple consecutive blank lines [Expected: 1; Actual: 2]
  • MD022/blanks-around-headings/blanks-around-headers: Headings should be surrounded by blank lines
  • MD032/blanks-around-lists: Lists should be surrounded by blank lines
  • MD034/no-bare-urls: Bare URL used
  • agflow.md : Illegal tag name. Use '<' to print '<'.
  • MD036/no-emphasis-as-heading/no-emphasis-as-header: Emphasis used instead of a heading

Hopelezz avatar Jun 11 '22 06:06 Hopelezz

Hello all,

This is my first time submitting to an open-source project. I appreciate the effort being placed on this project and want to contribute to it. I found some errors based on the Markdown guidelines set by DavidAnson. There were a few broken links as indicated, and even added office location based on one of the company's web pages.

I plan to do more should this go through. If there are any corrections to my submission, please let me know and I'll be happy to help.

ps. you might have to disregard my edit to the PULL_REQUEST_TEMPLATE.MD since this is where I logged my progress.

Hopelezz avatar Jun 11 '22 07:06 Hopelezz

Hi @Hopelezz I appreciate the enthusiasm here!

For code review, can I ask you to split this into multiple PRs?

  • updates
  • additions
  • formatting etc

The reason I ask is this I don't want to block company updates or additions when reviewing such a big change with the formatting.

Thanks!

dougaitken avatar Jun 12 '22 11:06 dougaitken

Also, can you link directly to the standards or whatever you're referring to, please?

dougaitken avatar Jun 12 '22 11:06 dougaitken

Hi @Hopelezz I appreciate the enthusiasm here!

For code review, can I ask you to split this into multiple PRs?

  • updates
  • additions
  • formatting etc

The reason I ask is this I don't want to block company updates or additions when reviewing such a big change with the formatting.

Thanks!

How do I go about doing this? Are these just different commits as the edits are done?

Also the other day I realized that this branch said "stale" should I have been working on the main? If I'm going to have to do any rework should I start from there instead?

Happy to help on the project. Any chance we could have a voice/video chat and discuss some of the points here?

As for the markdown lint: https://github.com/DavidAnson/markdownlint

Hopelezz avatar Jun 12 '22 12:06 Hopelezz

Hey @Hopelezz ah yes! Sorry I didn't even check that! Yes, you should be forking the repo, then branching main then opening a PR from there. I haven't setup multiple branches or such yet.

I think the best thing to do now would be to create branches based on each feature you're focusing on.

Happy to go over this async ideally but if it would help you, we can have a call some point. Email remote at dougaitken dot co dot uk. FYI, I'm based in the UK.

dougaitken avatar Jun 13 '22 22:06 dougaitken

@Hopelezz Are you still looking to contribute here?

dougaitken avatar Oct 09 '22 22:10 dougaitken

@Hopelezz

Let me know if you want to work on something like this again

dougaitken avatar Oct 21 '22 22:10 dougaitken