hardhat-vue-starter icon indicating copy to clipboard operation
hardhat-vue-starter copied to clipboard

Remove call to window.ethereum

Open valle-xyz opened this issue 3 years ago • 2 comments

Problem: The package uses Web3Modal, but in the initializing calls it depends on window.ethereum. This makes the app crash, when window.ethereum is not found (which is the case when Metamask is not installed).

Solution: Remove the calls from actions in accounts.js.

valle-xyz avatar Nov 29 '21 09:11 valle-xyz

Hi! I totally like your starter kit. Many thanks!!

I found some issues and fixed most of them. I can create pull requests if you like.

valle-xyz avatar Nov 29 '21 09:11 valle-xyz

hey, if you can do a PR that would be very much appreciated :)

remote-gildor avatar Nov 29 '21 22:11 remote-gildor