Tommy D. Rossi

Results 207 comments of Tommy D. Rossi

A good packaging solution and some good documentation would make this project an awesome alternative to Electron. I hope @patr0nus find a way to monetize this project and invest the...

I made a `.pnpmfile.cjs` to ensure some packages have only one version after every install ```js const enforceSingleVersion = [ 'react-hot-toast', // 'react', 'react-dom' ] function afterAllResolved(lockfile, context) { console.log(`Checking...

I have published a version of the package with the fix, you can use it via resolutions field in package.json ```json { "resolutions": { "react-virtualized": "git+https://[email protected]/remorses/react-virtualized-fixed-import.git#9.22.3" } } ```

I cannot build the package with esbuild because of this issue ``` error: No matching export for import "bpfrpt_proptype_WindowScroller" 75 │ import { bpfrpt_proptype_WindowScroller } from '../WindowScroller.js'; ```

The problem is probably the fact that now Next.js is loading `jose` browser bundle inside middleware instead of the Node one

I found the problem to be an injected polyfill of `TextDecoder` that always returns `''`, i didn't manage to reproduce the error in a smaller repro tho The bug is...

I got a different stack trace ``` /Users/morse/.nvm/versions/node/v10.21.0/lib/node_modules/ndb/services/ndd_service.js:21 throw error; ^ Error: Error: not implemented Error: not implemented at Ndb.FileSystem.getMetadata (https://domain/ndb.js:3:175663) at Persistence.FileSystemWorkspaceBinding.FileSystem.requestMetadata (https://domain/ndb.js:3:131825) at Workspace.UISourceCode.requestMetadata (https://domain/ndb.js:1:648280) at n (https://domain/ndb.js:3:141810)...

I think this can be fixed by passing `platform: 'node'` to esbuild, this will emit cjs annotation like these ```js 0 && (module.exports = { x }); ``` Here is...

i just noticed transform is missing that option, i opened an issue for that https://github.com/evanw/esbuild/issues/2362 Otherwise we could use the build api and mark everything as external

Sorry but what you said in #2362 about directly reading from disk does not apply to #38, because in that case the cjs file is a typescript file, so it...