Remko Popma

Results 381 comments of Remko Popma

I [added a test](https://github.com/remkop/picocli/blob/main/src/test/java/picocli/Issue2228.java), but it succeeds even before I make changes to fix the issue. Re-reading your comments now I have some idea on how to improve the test,...

I seem unable to reproduce the issue... Please see the updated test; this test passes.

> Thanks for the patience and time! > > I admit I am confused with your test You mention the test does not reproduce, but the code and running locally...

I have been able to run your reproducer project and I get this output: ``` C:\Users\remko\IdeaProjects\picocli-reproducer>gradlew build run --args="get --fail" > Task :cli:run Getting... [INFO] From ExecutionExceptionHandler ---- Exception: java.lang.RuntimeException:...

Thank you for that! Now I see what is happening: The `parseResult` object passed in to the `handleExecutionException` method is currently always the parseResult of the top-level command, regardless of...

@abelsromero I was about to make this change, but now I am having second thoughts. My concern is existing applications. There may be existing applications that depend on the current...

I am very, very hesitant to break anyone's application, even in major releases. An alternative I could consider would be adding a new `IExecutionExceptionHandler2` interface with a different method signature,...

Hi @vrdhn, my time to work on picocli is extremely limited these days. Mostly just bugfixes. However, I can discuss ideas for enhancements and review pull requests. I suggest that...

One more thing: we cannot use default methods on interfaces, since picocli requires only Java 5 (see [reasons why](https://github.com/remkop/picocli/wiki/FAQ#why-support-java-5)), and default methods were introduced in java 8.

Is this a picocli issue or a JLine issue?