partridge icon indicating copy to clipboard operation
partridge copied to clipboard

Published 20 hours ago • verified publisher icon remix

Bug fix: Preserve complete trips by resolving trip_ids from filters

Open invisiblefunnel opened this issue 4 years ago • 1 comments

Pre-1.0 versions of partridge preserved relationally-complete trips by resolving each filter clause to a set of reachable trip_ids. This behavior was mistakenly changed in the 1.0 refactor. You could be affected if you use partridge to filter by stop_times.txt or an ancestor of stop_times.txt in the dependency graph. This use case seems uncommon in practice.

To reproduce the issue, filter stops.txt by some field and observe that only stops matching the filter are kept, potentially leaving trips with missing stops. See the test case for details.

TODO

  • [x] review
  • [ ] merge
  • [ ] release

invisiblefunnel avatar Nov 17 '20 17:11 invisiblefunnel