remix icon indicating copy to clipboard operation
remix copied to clipboard

request.signal is never fired in dev server

Open DanielBaulig opened this issue 1 year ago • 1 comments

Reproduction

https://stackblitz.com/edit/remix-run-remix-jkyczz?file=app%2Froutes%2Fstream.tsx

Based on discussion: https://github.com/remix-run/remix/discussions/8461

The effects of the bug are twofold:

  • Actual abort signal behavior cannot be tested and verified using the dev server.
  • The dev server might leak resources that should have been freed when the request was cancelled.

Not that the bug only applies to the dev server. Using the express server the request abort signal is fired correctly.

System Info

See Stackblitz

Used Package Manager

npm

Expected Behavior

Dev server should print 'Received Abort!' when the response gets cancelled a second in.

Actual Behavior

Silence.

DanielBaulig avatar May 15 '24 18:05 DanielBaulig

Faced the same issue, this is very important please fix

remorses avatar Jul 24 '24 16:07 remorses

Resolved by #9976 and will be available in the next release 👍

brophdawg11 avatar Sep 13 '24 14:09 brophdawg11

🤖 Hello there,

We just published version 2.12.1-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Sep 18 '24 14:09 github-actions[bot]

🤖 Hello there,

We just published version 2.12.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Sep 19 '24 16:09 github-actions[bot]