remix icon indicating copy to clipboard operation
remix copied to clipboard

fix: convert undefined to null in an array

Open m-shaka opened this issue 1 year ago • 3 comments

Hi. JSON.parse(JSON.stringify({a: ["foo", undefined]})) is {a: ["foo", null]}, so Jsonfify<(string | undefined)[]> should be (string | null)[]

  • [ ] Docs
  • [x] Tests

Testing Strategy: typecheck test

m-shaka avatar May 02 '24 09:05 m-shaka

🦋 Changeset detected

Latest commit: 5531964e4c99f553255f5bfb3da6d35b28aa22c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/dev Patch
@remix-run/cloudflare Patch
@remix-run/deno Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/testing Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/architect Patch
@remix-run/express Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 02 '24 09:05 changeset-bot[bot]

Hi @m-shaka,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar May 02 '24 09:05 remix-cla-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar May 02 '24 09:05 remix-cla-bot[bot]