remix icon indicating copy to clipboard operation
remix copied to clipboard

Vite custom express migration docs don't mention 'source-map-support'

Open cythrawll opened this issue 1 year ago • 0 comments
trafficstars

Reproduction

Take a look at the custom express server Vite migration docs here: https://remix.run/docs/en/main/future/vite#migrating-a-custom-server

Also take a look at v2 migration docs here: https://remix.run/docs/en/main/start/v2#source-map-support

Note that v2 migration encourages adding of 'source-map-support'. But Vite migration docs it's absent in server.mjs.

System Info

chrome

Used Package Manager

npm

Expected Behavior

I am pretty sure (please correct me if i'm wrong) Vite takes care of source maps and we no longer need that module. If this is the case the migration docs should instruct to remove it. If it isn't the case and we still need it, we should include it in the diff to show that it was not removed.

Actual Behavior

source-map-support is not mentioned in Vite migration at all.

cythrawll avatar Mar 15 '24 20:03 cythrawll