remix icon indicating copy to clipboard operation
remix copied to clipboard

template(vite-cloudflare): Add _routes.json, _headers and .dev.vars to .gitignore

Open lasseklovstad opened this issue 1 year ago • 5 comments

👋 Hey, after testing the vite cloudflare template and deployed it I found some minor issues. It took me maybe 2 hours to find out to set Cloudflare settings 'Build output directory' to 'build/client'. Other then that is went smooth.

  • Added .dev.vars to .gitignore so you don't push your development env variables
  • After looking at cloudflare-pages template I saw _routes.json and _headers files. Don't see why they shouldn't be added to mirror the template for cloudflare.

lasseklovstad avatar Feb 08 '24 20:02 lasseklovstad

⚠️ No Changeset found

Latest commit: 555372bed34c791ca5363be9e97fcc1f3a464f28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 08 '24 20:02 changeset-bot[bot]

Hi @lasseklovstad,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar Feb 08 '24 20:02 remix-cla-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Feb 08 '24 21:02 remix-cla-bot[bot]

@lasseklovstad : Thank you for this. Seems to have fixed a production issue for me where assets were not being found. Much gratitude for your painstaking work in tracking this down.

mw10013 avatar Feb 28 '24 16:02 mw10013

Similar to @mw10013, I was having issues with asset requests returning 404 in production. This seems to have resolved the issue. Hope it gets merged soon. Thanks!

jwaltz avatar Mar 12 '24 16:03 jwaltz

Thanks @lasseklovstad, sorry these files were missing. I just validated that this all looks right locally and when deployed. Hope this saves some headache for future users of the template

brookslybrand avatar May 22 '24 20:05 brookslybrand