feat: expose tsconfigPath to AppConfig

[marwan38]

I can see this likely being used by others, no reason not to expose it AFAIK.

Our current use-case is that there are some properties in the tsconfig.json that I don't want to be available to the remix build. We have a mono-repo and we use the paths property in tsconfig to provide typings across all packages but at build time we expect remix to resolve the module in it's compiled form which is available through the node module resolution (symlinked inside node_modules as all other packages). This is caused by esbuild resolving paths through the tsconfig.

Here's a bit of code to demonstrate why I'd like this change:

Main tsconfig is used for IDE type resolution

// tsconfig.json
{
  "compilerOptions": {
    "paths": {
      "@internal-pkg/*": ["../internal-pkg/src/*"]
    }
  }
}

Whilst tsconfig.build is used strictly for building the application. This config ensures that the bundler resolves @internal-pkg/* from node_modules or whatever the module resolution type is.

// tsconfig.build.json
{
  "compilerOptions": {
    "paths": {}
  }
}

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 309e75aa71e422b374a342c8e318b6925711c1e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot[bot]]

Hi @marwan38,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot[bot]]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[michael-golfi]

Is there anything else required for getting this merged?

[marwan38]

@michael-golfi Not from my end. Let me fix the cla conflict

[marwan38]

@michael-golfi fixed

[michael-golfi]

Thanks @marwan38, I need this to satisfy some VSCode lints but also have remix build successfully

[LucilleH]

Is there anything pending on this still? Would really appreciate this going in!

[marwan38]

Is there anything pending on this still? Would really appreciate this going in!

Looks like I need to sync up the branch. I think it was up for a while anyways without movement. I'll fix it up sometime today.

[LucilleH]

@marwan38 friendly ping 😃 - this would really help us unblock some development pain 🙏

[marwan38]

@LucilleH Haha sorry! I totally forget. I have it patched at work so I never bothered too much to keep up with it. I highly recommend you do the same while waiting for this to get merged!

I've rebased the PR! Hopefully the team gets onto it soon :)

[marwan38]

Sorry.. I did make the fix but I believe I forgot to push it 😮‍💨 Hopefully this times the charm, assuming CI passes🤞

[Nick-Minutello]

Hi, is this PR making it into the release? Is there a work-around in the meantime?

[marwan38]

It's got conflicts again, but, due to the lack of response from the remix team I'm going to back off. @Nick-Minutello I've applied this via a patch. I dropped our use-case of this where I work.. also with the vite changes, you might be able to get away with configuring vite directly.

I'll leave this issue open for you, just in case.

[github-actions[bot]]

Thank you for opening this pull request, and our apologies we haven't gotten around to it yet!

With the release of React Router v7 we are sun-setting continued development/maintenance on Remix v2. If you have not already upgraded to React Router v7, we recommend you do so. We've tried to make the upgrade process as smooth as possible with our Future Flags. We are now in the process of cleaning up outdated issues and pull requests to improve the overall hygiene of our repositories.

We plan to continue to address 2 types of issues in Remix v2:

• Bugs that pose security concerns
• Bugs that prevent upgrading to React Router v7

If you believe this pull request meets one of those criteria, please respond or create a new pull request so it pops up on our radar (since github notifications may get lost in the noise 😕).

For all other issues/changes, ongoing maintenance will be happening in React Router v7, so:

• If this is a bug fix, please reopen against React Router v7
• If this is a new feature, please open a new Proposal Discussion in React Router, and if it gets enough community support it can be considered for implementation

If you have any questions you can always reach out on Discord. Thanks again for providing feedback and helping us make our framework even better!