remix icon indicating copy to clipboard operation
remix copied to clipboard

chore(remix-dev): update `@esbuild-plugins/node-modules-polyfill` package

Open MichaelDeBoey opened this issue 2 years ago • 1 comments

This will remove some deprecation warnings when installing @remix-run/dev, but most importantly: this is necessary for #5222

MichaelDeBoey avatar Jan 26 '23 17:01 MichaelDeBoey

⚠️ No Changeset found

Latest commit: b5ab62be6edd1d720319a725e1ba8ed51af58d56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 26 '23 17:01 changeset-bot[bot]

Hello @MichaelDeBoey ,

Do you know when this PR will be merged? It's a sticking point for me.

Best regards

nkrmr avatar Mar 28 '23 12:03 nkrmr

@nkrmr node: protocol imports are now supported by #5773 (instead of #5222)

@pcattori We do need this PR in order to close #4299 though

Since we have to wait for https://github.com/remorses/esbuild-plugins/pull/29 to be merged before we can continue, I'll make this a draft

MichaelDeBoey avatar Mar 29 '23 17:03 MichaelDeBoey

Thanks @MichaelDeBoey

jacob-ebey avatar Apr 13 '23 22:04 jacob-ebey

🤖 Hello there,

We just published version v0.0.0-nightly-987ee78-20230414 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Apr 14 '23 07:04 github-actions[bot]

@MichaelDeBoey still not good replacement our cloudflare bundle grew up by 45kB! All because of unnecessary added global polyfills

image

TrySound avatar May 06 '23 04:05 TrySound

@TrySound If you can come up with a better solution here, we're happy to accept PRs! 🙏

MichaelDeBoey avatar May 06 '23 17:05 MichaelDeBoey