remix icon indicating copy to clipboard operation
remix copied to clipboard

Published 20 hours ago • verified publisher icon remix-run

nonce support for defer inline scripts

Open kentcdodds opened this issue 2 years ago • 2 comments

Because security please :)

image

kentcdodds avatar Jan 20 '23 05:01 kentcdodds

Looks like this is a React issue as well: https://github.com/facebook/react/issues/26026

But Deferred will need these as well I think.

kentcdodds avatar Jan 20 '23 05:01 kentcdodds

React actually does support nonce, so we just need support for this in Remix's deferred-related scripts.

kentcdodds avatar Jan 20 '23 16:01 kentcdodds

This issue has been automatically marked stale because we haven't received a response from the original author in a while 🙈. This automation helps keep the issue tracker clean from issues that are not actionable. Please reach out if you have more information for us or you think this issue shouldn't be closed! 🙂 If you don't do so within 7 days, this issue will be automatically closed.

github-actions[bot] avatar Apr 18 '23 20:04 github-actions[bot]

Still relevant.

kentcdodds avatar Apr 18 '23 20:04 kentcdodds

I'm hitting this issue too. I wasn't successful in writing any tests for <Scripts />+<Await /> (JS beginner, sorry) so unfortunately can't make a PR but a tweak to #359 to pass the <Scripts /> props down through the internal DeferredHydrationScript seems to solve this issue and #5539, in case it gives someone else a head-start here.

jack-r-warren avatar May 02 '23 02:05 jack-r-warren

Fixed by #6389 and will be available in the next release

brophdawg11 avatar Jun 14 '23 14:06 brophdawg11

🤖 Hello there,

We just published version v0.0.0-nightly-ad9adee-20230615 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Jun 15 '23 07:06 github-actions[bot]

🤖 Hello there,

We just published version v0.0.0-nightly-12440f3-20230616 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Jun 16 '23 07:06 github-actions[bot]

🤖 Hello there,

We just published version 1.18.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Jun 21 '23 17:06 github-actions[bot]

🤖 Hello there,

We just published version 1.18.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Jun 26 '23 17:06 github-actions[bot]