remix icon indicating copy to clipboard operation
remix copied to clipboard

BUG: web-fetch premature close

Open tarngerine opened this issue 2 years ago • 3 comments

Related issue: #4993

  • [ ] Docs
  • [x] Tests

Testing Strategy:

yarn bug-report-test

Expected: no errors

Actual:

    at TLSSocket.onSocketClose (/Users/tarng/Code/oss/remix/node_modules/@remix-run/web-fetch/src/fetch.js:342:33)
    at TLSSocket.emit (node:events:538:35)
    at node:net:687:12
    at TCP.done (node:_tls_wrap:580:7)

  4 passed (6s)
  1 error was not a part of any test, see above for details

tarngerine avatar Jan 03 '23 20:01 tarngerine

⚠️ No Changeset found

Latest commit: 9e7fa3501abad6e45050aaf66557c5c6c283a454

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 03 '23 20:01 changeset-bot[bot]

Hi @tarngerine,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

remix-cla-bot[bot] avatar Jan 03 '23 20:01 remix-cla-bot[bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

remix-cla-bot[bot] avatar Jan 03 '23 20:01 remix-cla-bot[bot]

Curious if this is fixed with web fetch 4.3.6 which made a change to closing socket listeners on request abort.

brophdawg11 avatar Aug 03 '23 18:08 brophdawg11

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you have more information for us! 🙂

github-actions[bot] avatar Aug 17 '23 22:08 github-actions[bot]