remix icon indicating copy to clipboard operation
remix copied to clipboard

feat(remix-dev): make `entry.{client,server}.tsx` optional

Open mcansh opened this issue 2 years ago • 4 comments

made this before making a proposal like a dummy, but it's something we've talked about a bit internally

proposal here 👉 https://github.com/remix-run/remix/discussions/4601

Signed-off-by: Logan McAnsh [email protected]

Closes: #

  • [ ] Docs
  • [ ] Tests

Testing Strategy:

mcansh avatar Nov 14 '22 20:11 mcansh

🦋 Changeset detected

Latest commit: a7661fc3228a0f34e9d9953938cc4bdbcaaf52b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Minor
@remix-run/dev Minor
create-remix Minor
@remix-run/css-bundle Minor
@remix-run/architect Minor
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
@remix-run/deno Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 14 '22 20:11 changeset-bot[bot]

What about people using JS instead of TS? Do they need to have this file in their repo if they never changed it?

Should we also remove these files from our templates/examples?

MichaelDeBoey avatar Nov 14 '22 20:11 MichaelDeBoey

I think we should also run the JS migration on the file when people choose the js/jsx extension in the generator command?

definitely, this is still very much WIP. it also needs to go through the RFC phase as the og proposal was sort of just thrown together

mcansh avatar Dec 15 '22 22:12 mcansh

What about people using JS instead of TS?

if they "eject" we'll transform it to js

Do they need to have this file in their repo if they never changed it?

doesn't hurt

Should we also remove these files from our templates/examples?

that's up for debate, templates would get any update faster than it being bundled in the CLI ~~(unless we hit GitHub to get the file and use the bundled one if they're offline)~~

mcansh avatar Jan 10 '23 17:01 mcansh

🤖 Hello there,

We just published version v0.0.0-nightly-ecba23c-20230211 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

github-actions[bot] avatar Feb 11 '23 07:02 github-actions[bot]