remix
remix copied to clipboard
bug: scroll restoration does not work during development.
References: https://discord.com/channels/770287896669978684/1006494470356861024
Closes: #
- [ ] Docs
- [x] Tests
Currently if a reload gets triggered, either by the <LiveReload> component or manually by the user the scroll position always gets reset to 0.
Also added a small reproduction in Stackblitz https://stackblitz.com/edit/remix-cvejzc?file=app%2Froutes%2Findex.tsx Just change something and you will see the page will scroll to the top.
⚠️ No Changeset found
Latest commit: ebd223a95298eed9b24f987d32e8d79c06a28106
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Hi @gijsroge,
Welcome, and thank you for contributing to Remix!
Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.
You may review the CLA and sign it by adding your name to contributors.yml.
Once the CLA is signed, the CLA Signed label will be added to the pull request.
If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].
Thanks!
- The Remix team
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳
As of https://github.com/remix-run/remix/releases/tag/remix%401.10.0 this is fixed.