fix(remix-eslint-config): add `eslint-plugin-import` as peer dependency to prevent conflicts

[lensbart]

trafficstars

Closes: #4448

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: e010e3d5ec67a79116491824c5a555f7c5a67105

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[lensbart]

Hi @machour, thanks for the quick follow-up. I changed the base branch to dev.

I’m a bit confused here. My changes (correctly) show up as just two lines: But there seems to be a merge conflict, which, when I click Resolve conflicts, shows up as follows:

Feel free to rebase as you see fit/give me further instructions.

Regarding the CI: I currently see one failing check (remix-cla-bot Waiting for signature), but I have already contributed before, so not sure why it still asks.

Thanks!

[machour]

@MichaelDeBoey could you please do your thing here? 😅

@lensbart once properly fixed, you'll see the errors from the CI I was mentioning!

[lensbart]

@MichaelDeBoey I’m using Yarn PnP, so this is not a node-modules problem.

[MichaelDeBoey]

Hi @lensbart!

Are you still experiencing this problem?

I did some research & other ESLint configs (like eslint-config-react-app) do exactly the same thing as we do. Maybe you should remove your package cache & try again?

[github-actions[bot]]

This PR has been automatically closed because we haven't received a response from the original author 🙈. This automation helps keep the issue tracker clean from PRs that are unactionable. Please reach out if you have more information for us! 🙂

[lensbart]

Hi

Hi @lensbart!

Are you still experiencing this problem?

Hi @MichaelDeBoey, yes, this is still a problem with v1.19.1.

When you have an .eslintrc.js with two overlapping overrides conditions (e.g., one that covers all ts/tsx files in a monorepo, and one that covers the remix app folder), running ESLint will give an error:

ESLint couldn't determine the plugin "react" uniquely.

and/or:

ESLint couldn't determine the plugin "import" uniquely.

The second one is, for example, due to the latest versions of plugin:import/recommended and @remix-run/eslint-config using a different version of this plugin.

I did some research & other ESLint configs (like eslint-config-react-app) do exactly the same thing as we do. Maybe you should remove your package cache & try again?

It’s not a caching issue, I tried deleting the cache.

Could you kindly reopen this?

Thanks!

[lensbart]

I did some research & other ESLint configs (like eslint-config-react-app) do exactly the same thing as we do. Maybe you should remove your package cache & try again?

Based on all (sub)dependencies in use in my monorepo:

• Listing eslint-plugin-import as a dependency:
  • eslint-config-react-app
• Listing eslint-plugin-import as a peer dependency:
  • eslint-config-airbnb
  • eslint-config-airbnb-base
  • eslint-config-airbnb-typescript
  • eslint-import-resolver-alias
  • eslint-import-resolver-typescript