fix(remix-node): convert `fetch`'s `WebResponse` to `NodeResponse` so it matches the global

[mcansh]

closes #3480

Signed-off-by: Logan McAnsh [email protected]

Closes: #

• [ ] Docs
• [ ] Tests

Testing Strategy:

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 426370ca5b47ef4f96f2e6b221e9fce0ec511050

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages

Name	Type
remix	Patch
@remix-run/node	Patch
@remix-run/architect	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/serve	Patch
@remix-run/testing	Patch
@remix-run/vercel	Patch
@remix-run/dev	Patch
create-remix	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/css-bundle	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/react	Patch
@remix-run/server-runtime	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[MichaelDeBoey]

@acoreyj It seems like this is doing the same thing as your implementation in #5095 or am I missing some things?

[acoreyj]

@acoreyj It seems like this is doing the same thing as your implementation in #5095 or am I missing some things?

@MichaelDeBoey Ah wow I apparently did a bad job searching PRs, o well now I know a lot more about fetch.

Yes this is the same, and looking through the webfetch code it always resolves a webResponse and never rejects one so my extra checks and catch aren't necessary.

Plus the test strategy is definitely better

I think you are good to merge this and close mine.

[cliffordfajardo]

@mcansh following on this since thus PR seems this PR in the auth.js for adding remix support for the auth.js lib seems to be dependent on this PR getting merged 🙏

https://github.com/nextauthjs/next-auth/pull/6270

[MichaelDeBoey]

@mcansh I think this one can be merged as-is or is there anything that we're still waiting for?

[MichaelDeBoey]

@mcansh I don't think anything is holding us back from merging this one?

[thedotfilesdev]

Any chances that this one would be merged in the near future 🙏🏻 . Would be great to be able to use @auth/core together with the remix.

[jacob-ebey]

Should be closed by https://github.com/remix-run/remix/pull/7109

[github-actions[bot]]

🤖 Hello there,

We just published version v0.0.0-nightly-a179aa7-20230809 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions[bot]]

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!