remix icon indicating copy to clipboard operation
remix copied to clipboard

Bug: Back navigation from ErrorBoundary does not work properly #2896

Open machour opened this issue 3 years ago • 1 comments

Reproduce case for #2896

machour avatar Apr 19 '22 22:04 machour

⚠️ No Changeset found

Latest commit: eb49eb0fa8d12bcd8ae82c833a9d523c2bf46bb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 10 '22 10:07 changeset-bot[bot]

I don't think this is a bug, if you reload after a pushState the browser still has that history stack, so when you click the back button you get a popstate event instead of a document reload. If you don't include <Scripts/> in the ErrorBoundary then there's no client-side JS to detect the popstate and update accordingly.

I moved this test into the existing error boundary tests to ensure it's covered when <Scripts /> is present.

brophdawg11 avatar Jul 10 '23 20:07 brophdawg11