react-router
react-router copied to clipboard
remix-run
[Feature]: Callout inspiration from Ember.js in docs
What is the new or updated feature that you are suggesting?
Give a callout to Ember.js inspiration in react-router docs.
Much like the callout for react-router and Ember.js in Next.js RFC for layouts
Why should this feature be included?
Giving shoutouts to previous work is nice :D. Also gives context to newer developers that might not know the history of frontend technologies/frameworks.
https://github.com/remix-run/react-router/issues/15 https://github.com/remix-run/react-router/issues/22 https://github.com/remix-run/react-router/issues/26 https://github.com/remix-run/react-router/issues/187
https://guides.emberjs.com/release/routing/rendering-a-template/ https://reactrouter.com/docs/en/v6/components/outlet
http://ember101.ryanflorence.com/videos/004-master-detail-router-outlet-linkto
Those are all very old links from when we were still pre-1.0. The router has been through at least 3 major rewrites with entirely new APIs and systems.
The Outlet comparison is weak at best, since Michael was the one that implemented it, not Ryan. It also has inspiration points from Angular, as well as Ember. I wouldn't attribute it to any particular library.
We should definitely have an acknowledgments doc. In our early docs (almost a decade ago) we gave a hat tip to ember often:
- v1 readme: https://github.com/remix-run/react-router/tree/v1
- v3 readme: https://github.com/remix-run/react-router/tree/v3
But in v4 we moved to all render/component routing (which was not like ember at all anymore).
With v6 returning to our ember roots, we should absolutely acknowledge it, just like in our docs for @reach/router (https://reach.tech/router/credits)
I'll write it next week (also v6 draws from not just ember but preact router too). Thanks for the nudge @drewhamlett :)
