grunge-stack icon indicating copy to clipboard operation
grunge-stack copied to clipboard

feat: remove all TypeScript references when `isTypeScript` is passed as `false` to `remix.init`

Open MichaelDeBoey opened this issue 3 years ago • 2 comments
trafficstars

Just like https://github.com/remix-run/indie-stack/pull/127 & https://github.com/remix-run/blues-stack/pull/57


https://github.com/remix-run/remix/pull/3529 needs to be merged first

MichaelDeBoey avatar Apr 20 '22 00:04 MichaelDeBoey

#47 was merged 👍🏼

machour avatar Jun 08 '22 21:06 machour

Hello! So much time has passed and this stack is still broken when choosing JavaScript instead of TypeScript 😿. I know this PR is still a Draft but I'll start adding feedback already. I just wanna use JS with Remix 💿

williamrjribeiro avatar Aug 02 '22 14:08 williamrjribeiro

@williamrjribeiro @mcansh This one is good to go I think 👍

MichaelDeBoey avatar Aug 25 '22 21:08 MichaelDeBoey

@williamrjribeiro @mcansh This one is good to go I think 👍

can you fix the merge conflict? 😬

mcansh avatar Aug 25 '22 21:08 mcansh

@mcansh You were too fast 🙈

MichaelDeBoey avatar Aug 25 '22 21:08 MichaelDeBoey

@mcansh You were too fast 🙈

just doing one final check before logging off 😆

mcansh avatar Aug 25 '22 21:08 mcansh

@mcansh I added eslint-plugin-cypress to the wrong package.json 😅 Fixed now too, so ESLint will be OK now 👍

MichaelDeBoey avatar Aug 25 '22 21:08 MichaelDeBoey