examples
examples copied to clipboard
chore: update examples to be in line with templates
@chaance You last updated the chakra-ui
example, so you have some experience with emotion
. Could you maybe look into the emotion
example as well?
@helderberto Since you're the original creator of the emotion
& stitches
examples, we would like to have your help as well.
~@kumard3 If you have time to update the styled-components
example, we would like to welcome a PR for that.~
~@sergiocarneiro If you could help us updating the styletron
example, that would be awesome as well.~
@chaance @machour @mcansh If this PR is too big to review, I'm happy to chop this into a separate PR for each example.
Sure @MichaelDeBoey, I'll update the styletron
example.
Should I start now or wait for this PR to be reviewed?
@sergiocarneiro Thanks! 🙏
You can take _template
from this PR as a basis & just create a new PR if you want.
It appears React 18 streaming support is still a work-in-progress for CSS-in-JS libraries.
I found that at least styled-components
(#3658) and styletron
(#430) do not yet support it.
The required changes are officially described here, for those who are interested: https://github.com/reactwg/react-18/discussions/110
@chaance @machour @mcansh do you want me to chop this into a separate PRs for each example, so it's easier to review?
i'll review over lunch :)
alright, just gonna take a look at the server entries on my computer as the git diff on mobile is a little much 😆
If it would make your life easier, I'm happy to chop this up in multiple PRs. Whatever is easiest for you 🤷♂️
tried a few examples locally and of course the first one i tried happened to be sass which doesn't have any routes 🥴
@mcansh I'll add an index
route in a separate PR 👍