examples icon indicating copy to clipboard operation
examples copied to clipboard

chore: update examples to be in line with templates

Open MichaelDeBoey opened this issue 2 years ago • 3 comments

@chaance You last updated the chakra-ui example, so you have some experience with emotion. Could you maybe look into the emotion example as well?

@helderberto Since you're the original creator of the emotion & stitches examples, we would like to have your help as well.

~@kumard3 If you have time to update the styled-components example, we would like to welcome a PR for that.~

~@sergiocarneiro If you could help us updating the styletron example, that would be awesome as well.~


@chaance @machour @mcansh If this PR is too big to review, I'm happy to chop this into a separate PR for each example.

MichaelDeBoey avatar Oct 21 '22 16:10 MichaelDeBoey

Sure @MichaelDeBoey, I'll update the styletron example.

Should I start now or wait for this PR to be reviewed?

sergiocarneiro avatar Oct 22 '22 01:10 sergiocarneiro

@sergiocarneiro Thanks! 🙏 You can take _template from this PR as a basis & just create a new PR if you want.

MichaelDeBoey avatar Oct 22 '22 01:10 MichaelDeBoey

It appears React 18 streaming support is still a work-in-progress for CSS-in-JS libraries.

I found that at least styled-components (#3658) and styletron (#430) do not yet support it.

The required changes are officially described here, for those who are interested: https://github.com/reactwg/react-18/discussions/110

sergiocarneiro avatar Oct 22 '22 05:10 sergiocarneiro

@chaance @machour @mcansh do you want me to chop this into a separate PRs for each example, so it's easier to review?

MichaelDeBoey avatar Nov 14 '22 18:11 MichaelDeBoey

i'll review over lunch :)

mcansh avatar Nov 14 '22 18:11 mcansh

alright, just gonna take a look at the server entries on my computer as the git diff on mobile is a little much 😆

mcansh avatar Nov 14 '22 18:11 mcansh

If it would make your life easier, I'm happy to chop this up in multiple PRs. Whatever is easiest for you 🤷‍♂️

MichaelDeBoey avatar Nov 14 '22 18:11 MichaelDeBoey

tried a few examples locally and of course the first one i tried happened to be sass which doesn't have any routes 🥴

mcansh avatar Nov 14 '22 19:11 mcansh

@mcansh I'll add an index route in a separate PR 👍

MichaelDeBoey avatar Nov 14 '22 19:11 MichaelDeBoey